Conversation
tecosaur
added
REPL
|
I think this should be good to merge as soon as CI finishes if nothing comes up |
tecosaur
force-pushed
the
term-hist-ui-tweaks
branch
from
39bbce5 to
89311e5
Compare
Consecutive duplicates doesn't have any more semantic meaning to me compared to non-consecutive if you are filtering so I don't understand the justification for this over filtering out all duplicated entries. |
I'm not arguing for consecutive deduplication instead of unique, I just think there's a bit more to consider/check for deduplication for uniqueness, and so might as well get rid of consecutive duplicates in the meantime, since it's uncomplicated. |
|
There's one more fix I'll plop here if I can figure it out today |
tecosaur
force-pushed
the
term-hist-ui-tweaks
branch
2 times, most recently
from
a567ecf to
9264293
Compare
String indexing is such fun 🙃
This allows for search strings to be typed out as they are at the REPL, e.g. "julia> test123" (only in word mode). This seems natural enough that the > search mode is no longer needed.
Let's also avoid copying the entirety of `str` when dropping escaped characters while I'm at it.
tecosaur
force-pushed
the
term-hist-ui-tweaks
branch
from
9264293 to
34bbe85
Compare
|
I don't see
appear anywhere in the diffs or commit messages, was this dropped? If so: any objections, @KristofferC ? |
That was originally included as a stop-gap improvement, while other approaches were discussed more, but the unique filtering Kristoffer put in another PR was refined and merged faster than I expected. |
This is a small collection of (what I consider) innocuous fixes/tweaks to the history UI. (cherry picked from commit 41e50a7)
3 participants
This is a small collection of (what I consider) innocuous fixes/tweaks to the history UI.
If anything is bikesheddable, I'll split it off into a separate PR.
Closes: #60036